Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expanding trees below now possible on linux #2533

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Expanding trees below now possible on linux #2533

wants to merge 2 commits into from

Conversation

jannisCode
Copy link
Contributor

This pull request is linked to eclipse-jdt/eclipse.jdt.ui#1811. The changes introduced in that pull request make it possible to expand trees after the for loop on Linux, which was not previously possible.

It is crucial to review both pull requests together. Do not merge this pull request before eclipse-jdt/eclipse.jdt.ui#1811, as doing so would prevent tree expansion from working correctly on Linux.

@jannisCode jannisCode mentioned this pull request Nov 25, 2024
Draft
3 tasks
@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.jface/META-INF/MANIFEST.MF
features/org.eclipse.e4.rcp/feature.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch 
From be1347426630c2f8cd1cc467dd1bbf9e133eb983 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Mon, 25 Nov 2024 09:23:04 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/bundles/org.eclipse.jface/META-INF/MANIFEST.MF b/bundles/org.eclipse.jface/META-INF/MANIFEST.MF
index de20b5090a..47bd323cd1 100644
--- a/bundles/org.eclipse.jface/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.jface/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.jface;singleton:=true
-Bundle-Version: 3.35.100.qualifier
+Bundle-Version: 3.35.200.qualifier
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
 Export-Package: org.eclipse.jface,
diff --git a/features/org.eclipse.e4.rcp/feature.xml b/features/org.eclipse.e4.rcp/feature.xml
index 1c784e5664..f2aeefd62b 100644
--- a/features/org.eclipse.e4.rcp/feature.xml
+++ b/features/org.eclipse.e4.rcp/feature.xml
@@ -2,7 +2,7 @@
 <feature
       id="org.eclipse.e4.rcp"
       label="%featureName"
-      version="4.34.0.qualifier"
+      version="4.34.100.qualifier"
       provider-name="%providerName"
       license-feature="org.eclipse.license"
       license-feature-version="0.0.0">
-- 
2.47.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions GitHub Actions
Copy link
Contributor

Test Results

 1 520 files   -   301   1 520 suites   - 301   1h 50m 44s ⏱️ - 5m 55s
 7 725 tests ±    0   7 488 ✅  -     9  228 💤 ±  0  8 ❌ +8  1 🔥 +1 
22 676 runs   - 1 660  22 116 ✅  - 1 473  551 💤  - 196  8 ❌ +8  1 🔥 +1 

For more details on these failures and errors, see this check.

Results for commit 59c55a8. ± Comparison against base commit f5354b7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jannisCode @eclipse-platform-bot